OpenLevelEditor icon indicating copy to clipboard operation
OpenLevelEditor copied to clipboard
verified publisher icon OpenToontownTools

Cleanup

Open NathanX-S opened this issue 5 years ago • 3 comments

Realizing that these are pretty minor things, but things that should still be kept of, making a checklist issue. Nor are they necessarily urgent.

Checklist

  • [ ] Make stylefiles more sane, JSON maybe?
  • [ ] Replace all uses of 0/1 with bools for better readability/pythonism
  • [ ] Ensure all deprecated functions are replaced.
  • [x] Move LevelEditorPanel to a new file #25
  • [x] Move VisGroupPanel to a new file (or a file with LevelEditorPanel) #25

Please, if you feel anything should be added! Discuss! I also think that things need to be a little more compartmentalized. A 6k line file is insane and a pain.

NathanX-S avatar Nov 26 '20 06:11 NathanX-S

Yeah I had json in mind for style files at some point too. Definitely wanna do that since the current ones are abhorrent. Just need to include an auto converter as well

drewc5131 avatar Nov 26 '20 15:11 drewc5131

I wouldnt mind moving the editor panel and the visgroups panel to a different file. Definitely would make life easier

drewc5131 avatar Nov 26 '20 15:11 drewc5131

About the replace 0/1 with true/false, you can't do that with the IntVar variables for the panel, just the way PMW functions.

Although PMW sucks so I would love to transition to QT at some point if I can get that done

drewc5131 avatar Dec 01 '20 23:12 drewc5131