raven icon indicating copy to clipboard operation
raven copied to clipboard

add submodule update command to README for Building Raven

Open ddouglas opened this issue 1 year ago • 1 comments

ddouglas avatar Aug 28 '24 00:08 ddouglas

Hi @ddouglas! Not sure if you had a chance to see the discussion on #66, but it looks like we both have PRs to address the same issue.

I opted to supplement the introduction with a sentence indicating that a --recursive clone was necessary to build this project. I considered this sufficient for this use case.

However, after reviewing your PR, I see the merit in adding the command to update submodules to the build steps like you did. This way, the user is building with the correct, initialized submodules each time.

Let me know your thoughts, but I am leaning towards accepting your changes and closing my PR (#66). Thanks!

yaash45 avatar Sep 26 '24 19:09 yaash45

This PR was folded into #66 - thanks to you both for making Raven's build instructions better :)

jminor avatar Sep 28 '24 06:09 jminor