OpenTTD icon indicating copy to clipboard operation
OpenTTD copied to clipboard

Fix: Remove unwanted river artifacts after generation

Open SamuXarick opened this issue 1 year ago • 1 comments

Motivation / Problem

Artifacts left behind during river generation. Unnamed, 1935-01-01#18

Description

Remove unwanted river artifacts after generation. Unnamed, 1935-01-01#19

Limitations

This requires postponing ModifyDesertZoneAroundRiver to after river generation.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, game_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

SamuXarick avatar Jan 24 '25 14:01 SamuXarick

This ain't a generation error, it's just an Oxbow lake 🙃 But I will agree that the current „implementation” 😉 needs some more work and a small dud like the one presented in the screen–shot is undesirable.

Froozigiusz avatar Mar 19 '25 07:03 Froozigiusz

With swamps, this is no longer useful.

SamuXarick avatar Nov 20 '25 17:11 SamuXarick