stitching icon indicating copy to clipboard operation
stitching copied to clipboard

Cropper.prepare raises an exception when one rectangle does not overlap the ROI

Open carlosandujar opened this issue 3 years ago • 2 comments

Depending on the input, some images might not overlap the largest internal rectangle (see example).

Cropper.prepare raises an exception, but it would be more desirable to just ignore non-overlapping rectangles, or return their indices so that they can be removed as when subsetting to the largest component of the graph.

sample_mask

carlosandujar avatar Dec 06 '22 15:12 carlosandujar

Thanks for reporting the issue! I was not aware of that.

lukasalexanderweber avatar Dec 06 '22 21:12 lukasalexanderweber

another use case with images which can be used to test:

StitchingError: Rectangles do not overlap!

https://github.com/OpenStitching/stitching/discussions/172#discussioncomment-7593776

06_lir

lukasalexanderweber avatar Nov 17 '23 08:11 lukasalexanderweber