OpenSprites-next icon indicating copy to clipboard operation
OpenSprites-next copied to clipboard

Set up email

Open jamesd-uk opened this issue 9 years ago • 16 comments

Email addresses for general contact us, email verification, and DMCA hotline.

jamesd-uk avatar Jun 30 '16 15:06 jamesd-uk

Also for verifying email addresses, I assume? :package:

bates64 avatar Jun 30 '16 16:06 bates64

Our policy should probably be like Scratch - you can make an account but until your email is verified you can't upload resources.

bates64 avatar Jun 30 '16 16:06 bates64

Ruling out sendgrid because it wants my life story

jamesd-uk avatar Jun 30 '16 20:06 jamesd-uk

Sendgrid approved my account O_o

I just need info from @nanalan

jamesd-uk avatar Jun 30 '16 20:06 jamesd-uk

info

Such as?

Also I'm hoping to use some sort of .env and gitignored file to save api keys and the like - thoughts @MegaApuTurkUltra @liam4?

bates64 avatar Jul 01 '16 15:07 bates64

API keys?

Btw obviously hashed right?

towerofnix avatar Jul 01 '16 17:07 towerofnix

Just store it in an environment variable.

Or actually almost anything but on a git repo :P

matthewr6 avatar Jul 01 '16 17:07 matthewr6

+1 for environment variables. dotenv is now in package.json so we can easily do environment vars on our local copies

Just don't remove .env from .gitignore :P

MegaApuTurkUltra avatar Jul 03 '16 00:07 MegaApuTurkUltra

Any progress on this?

I guess it blocks the "forgot password" feature of #84

MegaApuTurkUltra avatar Jul 27 '16 18:07 MegaApuTurkUltra

I have a SendGrid account set up, I'm just waiting for someone to ask me for API keys.

jamesd-uk avatar Jul 28 '16 08:07 jamesd-uk

I have a SendGrid account set up, I'm just waiting for someone to ask me for API keys.

asks

bates64 avatar Jul 28 '16 10:07 bates64

I've implemented SendGrid in a84fd4f7d6b268bececa5830851dcb1101284f05 - you can send emails now, but somebody needs to make/get a cross-client email template...

bates64 avatar Jul 28 '16 11:07 bates64

@MegaApuTurkUltra email template pls

bates64 avatar Jul 30 '16 07:07 bates64

We should do the template in handlebars. Can handlebars render to string?

MegaApuTurkUltra avatar Jul 30 '16 17:07 MegaApuTurkUltra

yep, it can render anything (not just html).

bates64 avatar Jul 31 '16 16:07 bates64

Just set up templating - see https://github.com/OpenSprites/OpenSprites-next/blob/master/server/utils/email.js#L44-L65

Currently an html version and a text version are templated and sent.

I haven't actually tested sending an email though, for lack of a sendgrid api key.

MegaApuTurkUltra avatar Aug 01 '16 16:08 MegaApuTurkUltra