amplify icon indicating copy to clipboard operation
amplify copied to clipboard

[front-end] prepare vue components for Stripe update

Open DietBepis1 opened this issue 2 years ago • 12 comments

Amplify has a Constituents table to store user data; however, it is currently unused. You can see in the wiki that the Constituents table should have a first_name and last_name field. To prepare the app to store constituent data, the front-end will need to be modified in a number of ways.

Todos:

  • [x] Update the SignName component to have a first name and last name field. There is already a data validation for name that can be copied over.
  • [ ] Update the Vuex store to have a first name and last name property for the userData object.
  • [ ] There is actually a bug in the TakeAction.nextPagemethod that is overriding userData with an empty object. Fix this method so it doesn't write over the data that the user just filled out.
  • [ ] I believe that Lob only has a name property for the letter, so create a computed property that concatenates the user's name together for both the letter display and also when the user is passed to /createLetter.
  • [ ] Any other spots that need fixing that I might have missed.

DietBepis1 avatar Mar 05 '23 01:03 DietBepis1

Hi @DietBepis1, I am a full stack developer but new to open source. Pls guide me on how can I get started with contributing to this organization

lokeshkumar0001 avatar Mar 06 '23 07:03 lokeshkumar0001

@lokeshkumar0001 Hey Lokesh, welcome to open-source and Program Equity! 😊 I would recommend you have a look at the codebase and the issue details and ask any specific questions you come across.

paramsiddharth avatar Mar 06 '23 14:03 paramsiddharth

@paramsiddharth Thanks for your help. May I know where to ask any specific questions. Do you have any slack or discord channels? or anything like that?

lokeshkumar0001 avatar Mar 06 '23 15:03 lokeshkumar0001

@paramsiddharth Thanks for your help. May I know where to ask any specific questions. Do you have any slack or discord channels? or anything like that?

@lokeshkumar0001 Sure! Here's our Slack: https://join.slack.com/t/programequity/shared_invite/zt-1p1buco3b-yUXjDaKSz3OSJfaHj88Y4g

paramsiddharth avatar Mar 06 '23 15:03 paramsiddharth

Hi all! I'm going to pick this up, if that's ok with everyone! Glenn sent it to my pod leader as something that I might be able to contribute on.

smgraywood avatar Mar 06 '23 17:03 smgraywood

Hey, is it ok if I join on this issue? I'd like to work on it. @DietBepis1 @paramsiddharth

christina-ml avatar Mar 29 '23 17:03 christina-ml

I worked on the first todo item for the SignName component: Update the SignName component to have a first name and last name field. There is already a data validation for name that can be copied over.

Notes:

  • Remove name text field
  • Add firstName text field
    • Update rule to require firstName field
    • Update placeholder text
  • Add lastName text field
    • Update rule to require lastName field
    • Update placeholder text
  • Update data object with firstName and lastName fields
  • Update computed form() function with first_name and last_name fields

Pull request: https://github.com/ProgramEquity/amplify/pull/547

christina-ml avatar Apr 04 '23 23:04 christina-ml

Branch: issue-521

Dunridge avatar Oct 12 '24 19:10 Dunridge

hi @Dunridge and @christina-ml are you working on this issue? I would like to collaborate if so. If you aren't, I can take care of it! Thanks

santi-jose avatar Oct 13 '24 03:10 santi-jose

@santi-jose @Dunridge I have updated my Pull Request #547. Can someone please review my pull request, to see if it can be merged?

christina-ml avatar Oct 13 '24 05:10 christina-ml

Feel free to assign yourself to work on this issue 🙂

christina-ml avatar Oct 13 '24 05:10 christina-ml

Hi @christina-ml nice to see you here @santi-jose this issue is outdated I will close it You can have a look at https://github.com/OpenSourceFellows/amplify_docs/discussions/11 for front-end issues, hope that helps

davidchapuis avatar Oct 13 '24 14:10 davidchapuis