amplify icon indicating copy to clipboard operation
amplify copied to clipboard

Potential fix for code scanning alert no. 20: Use of externally-controlled format string

Open priyadam opened this issue 6 months ago • 2 comments

Potential fix for https://github.com/OpenSourceFellows/amplify/security/code-scanning/20

To fix this issue, we should ensure that untrusted user input is never used as a format string in a logging or formatting function. The best and most reliable way to do this in Node.js is to provide a constant format string with %s placeholders, and pass all untrusted data as arguments to be interpolated. This way, even if the user supplies malicious format specifiers, they will be treated as plain strings and not interpreted. Specifically, in console.log(paymentIntent, amount, eventOutcome), we should change this to console.log('%s %s %s', paymentIntent, amount, eventOutcome). No new imports or definitions are needed.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

priyadam avatar Jul 21 '25 20:07 priyadam

emote

github-actions[bot] avatar Jul 21 '25 20:07 github-actions[bot]

Hello there, thanks for opening your first Pull Request. Someone will review it soon.

github-actions[bot] avatar Jul 21 '25 20:07 github-actions[bot]