open-simulation-interface icon indicating copy to clipboard operation
open-simulation-interface copied to clipboard

feat(SensorModelling) add pixelcoordinates to CameraPoint

Open RIFJo opened this issue 3 years ago • 0 comments

refers to #627

Signed-off-by: RIFJo [email protected]

#### Reference to a related issue in the repository #627

Add a description

add two integer-fields (pixel_x and pixel_y) to CameraPoint message to allow image-coordinate specification for CameraDetectionData. I chose this solution over using Vector2d (because it uses doubles) or creating a custom type "ImageCoordinates" with two integer fields - which would be another good alternative, but i was unsure where (as in "which file") such a type should be placed.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • [x] My suggestion follows the style and contributors guidelines.
  • [x] I have taken care about the documentation.
  • [x] I have done the DCO signoff.
  • [ ] My changes generate no errors when passing CI tests.
  • [x] I have successfully implemented and tested my fix/feature locally.
  • [ ] Appropriate reviewer(s) are assigned.

If you can’t check all of them, please explain why. If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

RIFJo avatar Jun 02 '22 08:06 RIFJo