open-simulation-interface icon indicating copy to clipboard operation
open-simulation-interface copied to clipboard
verified publisher icon OpenSimulationInterface

Align TrafficLight with OpenDIRVE and OpenSCENARIO

Open adrianschultz opened this issue 3 years ago • 3 comments

Reference to a related issue in the repository

https://github.com/OpenSimulationInterface/open-simulation-interface/issues/611

Add a description

I changed the traffic lights according to the description in https://github.com/OpenSimulationInterface/open-simulation-interface/issues/611

Changes to be reviewed are only in osi_trafficlight.proto The other changes are documented in https://github.com/OpenSimulationInterface/open-simulation-interface/issues/584 and https://github.com/OpenSimulationInterface/open-simulation-interface/pull/613 and should be reviewed there.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • [x] My suggestion follows the style and contributors guidelines.
  • [x] I have taken care about the documentation.
  • [ ] I have done the DCO signoff.
  • [x] My changes generate no errors when passing CI tests.
  • [x] I have successfully implemented and tested my fix/feature locally.
  • [x] Appropriate reviewer(s) are assigned.

adrianschultz avatar Jan 27 '22 10:01 adrianschultz

For this pull request we (the Harmonization group) agreed on waiting for the outcome of the potential OSI, OpenSCENARIO and OpenDRIVE workshop on dynamic traffic signals/signs.

adrianschultz avatar Apr 08 '22 10:04 adrianschultz

Maybe we can add @arauschert here for some input regarding the harmonization with OpenSceanrio

jdsika avatar Jun 15 '22 14:06 jdsika

Maybe we can add @arauschert here for some input regarding the harmonization with OpenSceanrio

Sure. Please invite me, if there are any discussion meetings. From my POV we first have to decide, what OSI shall represent:

  1. the instantaneous perceivable state (e.g. ON/OFF) or the current interpreted phase (e.g. constant/flashing/off)
  2. only one light bulb or the whole traffic light box including one or multiple light

I would also separate the issue of missing icons for U-turn, bicycles and tram, which can be easily fixed (v3.x) from the harmonization issue (v4)

arauschert avatar Jun 21 '22 06:06 arauschert

WG meeting Harmonization response:

After termonology is clear, please update. Check icons if values are missing there. Consider combined semantic meaning, e.g. red+yellow on german traffic ligts has a special meaning.

thempen avatar Nov 23 '22 10:11 thempen