open-simulation-interface icon indicating copy to clipboard operation
open-simulation-interface copied to clipboard

Adding RoadConditions to EnvironmentalConditions

Open ClemensLinnhoff opened this issue 5 years ago • 6 comments

Describe the feature

RoadConditions in OSI are quite hidden. They are currently part of the lane classfication. For me, values like water film height or ice on the pavement are environmental conditions.

Describe the solution you would like

Therefore I propose to move the RoadConditions to the environmental conditions to make it more intuitive to find them. I know, that environmental conditions are supposed to be global values at the moment, which I would also question. This might be a discussion for another day, but conditions like fog can also occur locally. For the RoadCondition a lane ID parameter would fix this issue, when they are moved to the environmental conditions.

Describe the backwards compatibility

This would create some problems for backwards compatibiliy, so it could only be done in a major release.

ClemensLinnhoff avatar Sep 07 '20 06:09 ClemensLinnhoff

Since it is a property of the Lane, I don't see why it should be added to environmental conditions. For example, you have a road with 4 lanes, but a water film only on one of them, having the road condition under environmental conditions will make it harder to describe the situation.

However, I would see that it should be moved directly under Lane and not under osi3::Lane::Classification

@ClemensLinnhoff, what do you think?

kmeids avatar Nov 27 '20 13:11 kmeids

I agree with putting the road condition directly under lane and I get the argument that it does not have to be in the environmental conditions class. However, we can continue this discussion on the wetness of surfaces other than the pavement. Would you see conditions like surface wetness also in the individual objects class, like stationary objects? The same class "RoadCondition" could be used directly for other surfaces and would just have to be renamed. Then it would also be more intuitive, if every object (incl. lanes) had a surface conditions class.

ClemensLinnhoff avatar Dec 14 '20 07:12 ClemensLinnhoff

I agree! As you have suggested this should also be included under static objects. @clemenshabedank, it's short notice but I'll forward you the invitation to today's meeting.

kmeids avatar Dec 14 '20 08:12 kmeids

@kmeids I guess you mean @ClemensLinnhoff

clemenshabedank avatar Dec 14 '20 10:12 clemenshabedank

@ClemensLinnhoff, Is this something that you would like to further discuss in the next SensorModeling meeting?

kmeids avatar Jun 04 '21 09:06 kmeids

Yes, I'd be happy to discuss this, but unfortunately the next meeting I could take part in would be on July 9th.

ClemensLinnhoff avatar Jun 08 '21 11:06 ClemensLinnhoff