open-simulation-interface icon indicating copy to clipboard operation
open-simulation-interface copied to clipboard

Sign of uncertainties in Dimension3d

Open ainar opened this issue 6 years ago • 6 comments

https://github.com/OpenSimulationInterface/open-simulation-interface/blob/a8fb7ccebe22c14662a86b5649077785ed5adeb3/osi_common.proto#L92

On this line, the documentation let the uncertainties on Dimension3d values be negative. However an uncertainty, according to the RMSE formula, can only be positive. Is it an error or intentional?

ainar avatar Apr 15 '19 12:04 ainar

Interesting finding! Needs to be checked

ghost avatar Apr 15 '19 15:04 ghost

By going further, I notice that actually the problem can be bigger and is generic to every uncertainty.

It is difficult to characterize an error/tolerance on a measurement. The error/tolerance can depend on more factors, we need to define on which and how many. For example, if a Dimension3d message characterize the dimension of a car, its tolerance depends on environmental conditions, the temperature of the car, its materials, etc. but the tolerance will not change regardless if you measure the width, the length or the height.

Depending on how precise you want OSI to be, these informations should be implemented in a specific new message for each kind of tolerance.

ainar avatar Apr 16 '19 12:04 ainar

@PhRosenberger the definition of uncertainties is also a major part in the ISO23150 and should be clarified in #367

jdsika avatar Feb 19 '20 10:02 jdsika

@PhRosenberger the definition of uncertainties is also a major part in the ISO23150 and should be clarified in #367

I agree.

PhRosenberger avatar Feb 19 '20 11:02 PhRosenberger

Could you have a look at his @FlorianMueller87, please?

jdsika avatar Jun 15 '22 14:06 jdsika

I agree that uncertainties could be positive and negative. The ISO defines them with real value types, see e.g. A.1.23 of the ISO. The ISO defines the error model in B.4.1 which includes trueness and precision, B.4.1.3.2. For the harmonisation with ADI an error-model would also be necessary.

FlorianMueller87 avatar Jun 21 '22 11:06 FlorianMueller87