OpenSCAP
Fix 1798
Hi, @DoctorPepper12. We are still considering your approach for probes "pluginization", but here is the list of red flags we currently see:
- It's windows only (though it's more of an orange flag, we might conclude that is it not very interesting feature for *nix, jury is still out on this one);
- A lot of functions suddenly became public API, like
oscap_string_to_enum, we would prefer not to make such a commitment; - This feature has no test coverage whatsoever.
Also, I would kindly ask you to properly re-base the PR against maint-1.3 and squash appropriate parts of your initial development history, there is no benefit in it for the project.
Please try to adhere to the https://github.com/OpenSCAP/openscap/blob/maint-1.3/docs/contribute/contribute.adoc, especially in terms of code style (we try to preserve existing code style if we are making small changes for the sake of code readability).
I don't quite get the purpose of plugin/OVAL/probes/windows/file_probe, it's just a dummy. Maybe it is an experimental piece of code slipped into the PR? It should be removed then.
It’s ok as long as it’s published per the license!
Sent from my iPhone
On Sep 6, 2021, at 3:53 PM, Evgeny Kolesnikov @.***> wrote:
I don't quite get the purpose of plugin/OVAL/probes/windows/file_probe, it's just a dummy. Maybe it is an experimental piece of code slipped into the PR? It should be removed then.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.
