osrd icon indicating copy to clipboard operation
osrd copied to clipboard

editoast: add railjson import command

Open elzinko opened this issue 3 years ago • 3 comments

close #1841

PR to import railjson format using command line. Persist method will be implemented by composition using every schema sub parts.

elzinko avatar Oct 11 '22 16:10 elzinko

Codecov Report

Merging #2080 (66b30fa) into dev (519d801) will decrease coverage by 0.12%. The diff coverage is 79.71%.

:exclamation: Current head 66b30fa differs from pull request most recent head c5e45d0. Consider uploading reports for the commit c5e45d0 to get more accurate results

@@             Coverage Diff              @@
##                dev    #2080      +/-   ##
============================================
- Coverage     78.97%   78.85%   -0.13%     
  Complexity     1696     1696              
============================================
  Files           278      280       +2     
  Lines          7687     7845     +158     
  Branches        959      959              
============================================
+ Hits           6071     6186     +115     
- Misses         1266     1309      +43     
  Partials        350      350              
Flag Coverage Δ
editoast 68.21% <79.71%> (+0.42%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/client/mod.rs 100.00% <ø> (ø)
editoast/src/generated_data/error/routes.rs 89.58% <ø> (ø)
editoast/src/generated_data/mod.rs 94.23% <ø> (ø)
editoast/src/generated_data/utils.rs 78.94% <ø> (ø)
editoast/src/schema/errors.rs 88.23% <ø> (ø)
editoast/src/schema/operation/create.rs 97.43% <ø> (ø)
editoast/src/schema/operation/delete.rs 53.84% <ø> (ø)
editoast/src/schema/operation/update.rs 62.06% <ø> (ø)
editoast/src/tables.rs 0.00% <0.00%> (ø)
editoast/src/main.rs 20.00% <15.38%> (-8.58%) :arrow_down:
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Oct 12 '22 09:10 codecov[bot]

@elzinko please run cargo fmt and amend your change

multun avatar Oct 12 '22 09:10 multun

@flomonster review done. next step is to implement railjson persist (or persist_batch) and add all tests to fix codecov

elzinko avatar Oct 12 '22 13:10 elzinko

Can you ammend your commits.

done. More tests have been added so I keep newer commits separate for simpler review. Then I'll amend them again

elzinko avatar Oct 27 '22 20:10 elzinko