Incorrect tags on commits causes docker images to not be published on Dockerhub

[ghost]

Even after https://github.com/OpenRCT2/openrct2-docker/commit/1d3628e83aeea5260c574403e1b6989edf475473 , latest returns v0.4.19

sudo docker run --rm openrct2/openrct2-cli:latest --version
OpenRCT2, v0.4.19 (088081d on HEAD)
Linux (x86-64)
Network version: 0.4.19-0
Plugin API version: 104
Current park file version: 50
Minimum park file version: 50
Breakpad support disabled

The step "Publish docker images" is skipped in the CI workflow, e.g. for 0.4.20 : https://github.com/OpenRCT2/openrct2-docker/actions/runs/13637244952/job/38118930212

I have identified that multiple versions are missing (e.g. 0.4.19 and 0.4.20). I think it may be because the release tags on the commits for v0.4.19.1 and 0.4.20 don't match with the proper ci.yml. For example, the release tagged as 0.4.20 has a ci.yml with values for tag and dockerlst of 0.4.19 https://github.com/OpenRCT2/openrct2-docker/commit/5387921e804d260ba861c689ec0b2b5af8b030b1

The CI workflow (ci.yml) is configured to only push Docker images when there's a git tag that starts with 'v' (the condition if: startsWith(github.ref, 'refs/tags/v')) : https://github.com/OpenRCT2/openrct2-docker/blob/master/.github/workflows/ci.yml#L44

Additional logs :

sudo docker run --rm openrct2/openrct2-cli:0.4.19 --version
Unable to find image 'openrct2/openrct2-cli:0.4.19' locally
0.4.19: Pulling from openrct2/openrct2-cli
Digest: sha256:fd49aa67a1861b2381f1f73364f3bb5e18b22d833c6aaacb414b05ad8838d5c6
Status: Downloaded newer image for openrct2/openrct2-cli:0.4.19
OpenRCT2, v0.4.19 (088081d on HEAD)
Linux (x86-64)
Network version: 0.4.19-0
Plugin API version: 104
Current park file version: 50
Minimum park file version: 50
Breakpad support disabled

sudo docker run --rm openrct2/openrct2-cli:0.4.19.1 --version
Unable to find image 'openrct2/openrct2-cli:0.4.19.1' locally
docker: Error response from daemon: manifest for openrct2/openrct2-cli:0.4.19.1 not found: manifest unknown: manifest unknown.

sudo docker run --rm openrct2/openrct2-cli:0.4.20 --version
Unable to find image 'openrct2/openrct2-cli:0.4.20' locally
docker: Error response from daemon: manifest for openrct2/openrct2-cli:0.4.20 not found: manifest unknown: manifest unknown.

[Gymnasiast]

I don’t think I can very easily fix v0.4.19 and v0.4.19.1, but can you check if v0.4.20/latest is now correct?

[ghost]

Thank you, that fixed it :

docker run --rm openrct2/openrct2-cli:latest --version
OpenRCT2, v0.4.20 (1c1b6d4 on HEAD)
Linux (x86-64)
Network version: 0.4.20-0
Plugin API version: 104
Current park file version: 51
Minimum park file version: 51
Breakpad support disabled

Would you be interested in a proposal for a more maintainable workflow for this repository? I believe there’s an opportunity to make the process less manual and reduce the likelihood of errors. I’d be happy to discuss these ideas further or submit a draft pull request for review if there’s interest. Let me know your thoughts

[Gymnasiast]

Yes, I would be interested to hear more.

[Aartsie]

Is there any progress on this issue? I see that they forgot to update the ci.yml to 0.4.24 which causes that there is no build on docker hub.

I can help if there is help needed, let me know!

[AaronVanGeffen]

@janisozaur Could you look into this?

[Aartsie]

For 0.4.24 I made an MR #25 but this is not the automated solution I am thinking about.