OpenRCT2
Add wall version of beta brick terrain edge
Resolves #340. Created a new wall object that match the texture of the brick wall beta terrain edge.
I'm a bit unsure if it would make sense to include the rock walls as there's no wall version of the final/RCT2 rock edge.
For the names i would just shorten them to "Brick Wall" and "Rock Wall" or even just "Wall" as the wall names in vanilla are pretty generic.
For the object ids should remain "official" as they were not a part of the rct1 beta, they're just official additions based on the beta assets.
I didn't even consider that some of the terrain edges don't have corresponding walls. I probably wouldn't have made the rock wall if I'd thought about it.
If anyone feels strongly about not having them, that's fine by me.
I think it would be really nice to have the other wall edge textures as scenery too
I generally want to keep the brakes on adding too much extra content. Could you put forth your arguments for including these as official content?
Having the beta brick wall would create a nice parity with how the existing brick terrain edge has a wall that goes with it.
The rock wall doesn't fit as well and I don't have any strong arguments about keeping that one.
I could see the brick wall fit in with the default objects, I could see rock wall (as well as for the non-beta versions) be a non-essential official object. @Gymnasiast good ideas for the object store, too?
For what it's worth, the brick wall was the only one i mentioned on the issue that prompted this PR. #340.
I'm happy with this. I do want @Gymnasiast's opinion though. He has ideas on which objects to release with the main package and which objects would be additional content.
Ingame the sprites look good to me. However i would change the walls & roofs scenery group so they're listed between the final brick walls & iron walls as their current placement at the very end of the group seems strange.
Also i would add myself and fidwell to the authors list. I'm the secondary author of the initial terrain edge and fidwell converted it to a wall here with custom sloping sprites so i feel like he deserves a credit at least. Alternatively "OpenRCT2 developers" could be used as it is on other objects.
I reordered the group and added "OpenRCT2 developers" to the credit list. That feels more appropriate to me, since neither of us made new art; we just converted pre-existing assets.
I'm happy with this. I do want @Gymnasiast's opinion though. He has ideas on which objects to release with the main package and which objects would be additional content.
I think this would be more suitable for a featured/add-on set, rather than directly bundled with the game.