OpenPrinting
Add jobs' original hostname indication in the Jobs table
I am using a Canon MF4550d MFU. Upon installation on Windows, there are two different drivers I can use: Microsoft IPP Class Driver and Canon MF4550D URFII LT Driver.
The first one, should it be called Microsoft driver for short, reports usernames in HOSTNAME\USERNAME format. But as the standard driver, it only has basic functionality and so I prefer to use the Canon driver.
The other driver (Canon MF4550d URFII LT) reports just the user name. It can be a problem if an user uses the same username on different computers, which often happens on Windows PCs.
This is the reasoning behind the changes I made. It would be great to also add an option to choose whether the hostname should be displayed or not. But my knowledge in C++ doesn't allow me to do that.
Sounds reasonable, but I would print the hostname only if we have username (it is not 'Witheld') and the hostname is not localhost. @michaelrsweet WDYT?
Mentioned in the comment in the issue - I would print the hostname only if we have username and if the hostname is not localhost.
This obviously can be done, but I have some questions about the restrictions you make.
-
if there is no username and no host name, that means the user can't identify the origin of the job completely? Or is the hostname null in the case of the username being null?
-
if there is a Linux system with many users, and they are printing jobs from different user accounts, but the printer is also shared and other users with possibly same usernames print jobs, wouldn't the loss of "localhost" hostname cause confusion? E. G.
John printed Report.rtf at Mon Jan 3 10:30 AM John @ OFFICE3PENTIUM printed Report.rtf at Mon Jan 3 10:31 AM
Additional point of view: some localhost jobs aren't assigned any username at all, they are listed as "anonymous" (e. g. Print test page from Web UI). In the case of test pages this isn't really a problem, but if there is something serious printed from anonymous, it can be frustrating.
Anyway, in case I am wrong with my assumptions, I will make the required change.
The presence of the hostname (really domainname) in the username field is a Windows-ism and not something that can be consistent. Moreover, the proposed change will just yield the hostname twice.
Don't think we want this, sorry...
