cups icon indicating copy to clipboard operation
cups copied to clipboard

Test suite: If holding supported, add a new print job for cancelling

Open zdohnal opened this issue 3 years ago • 4 comments

On some quicker machines the print-job operation finishes quicker than we can cancel it in the test - so add job-hold-until job template attribute if the printer supports it, which will hold the job until it is cancelled by the next test.

The next test passes because it has both statuses (correct and error one) as expected, but cupsd generates an additional error in log if the job cancelling fails, which would be more dirty to cover in run-stp-test.sh.

There is a loophole when the error is still generated - if the printer/machine is quick enough to finish the job, but the machine/printer doesn't support job holding at the same time. IMHO the current patch should cover most cases.

Fixes? #155

zdohnal avatar Jul 27 '22 16:07 zdohnal

@shirelyhhdl @sp1ritCS please test it and let me know whether it helps.

zdohnal avatar Jul 27 '22 16:07 zdohnal

@michaelrsweet I haven't found out how to make a specific attribute optional, so I've added a new print job with job-hold-until if the printer supports it, and adjusted requests count in run-stp-tests.sh accordingly.

zdohnal avatar Jul 27 '22 17:07 zdohnal

I don't know how soon I'm able to test it, but I'll try

sp1ritCS avatar Jul 27 '22 20:07 sp1ritCS

@sp1ritCS @shirelyhhdl any updates?

@michaelrsweet WDYT about the changes?

zdohnal avatar May 31 '23 13:05 zdohnal