Mixtral support
I tried to support Mixtral by implementing MoE. The current problem is the inaccurancy in tensor after passing the MHA layer causes the wrong selection between the experts for certain tokens. This leads to a very low quality. tested with and without quantization.
I appreciate if you have any idea about this.
maybe you can check qkv before applying rotary to make sure the issue does not come from rotary embeddings/
also are those longer "tabs" on purpose ? makes the PR more difficult to read.
I already compared the tensor before passing the rotary embeddings. I seems like there is already a difference before the rotary embeddings (compared with transformers for HF). The input of self attention has a very high accurancy (+- < 0.0001) but the output of self attention has an error (+- ~0.002) then after passing post norm (+- <0.02). The drawback is that I can log only some values at the begin and at the end of the tensor in CT2, but the first and the last token work correctly, so the small inaccuracy in theses values are useless to conclude. I think should implement new version of log for StorageView to make the debugging more efficiency in the future.
I will fix the longer tabs, because I dev in a remote machine, the indent's configuration sometimes goes wrong.