SyMPC icon indicating copy to clipboard operation
SyMPC copied to clipboard

Add concurrency to kill prev CI task

Open shubhank-saxena opened this issue 4 years ago • 17 comments

Description

This fixes #102 This PR aims to add feature, which kills previous CI job, if new change is committed.

Checklist

shubhank-saxena avatar Aug 13 '21 07:08 shubhank-saxena

@rasswanth-s I am not able to join OpenMined Slack Channel 😮‍💨

shubhank-saxena avatar Aug 13 '21 07:08 shubhank-saxena

I am not sure, Did you try the opemined.org website, I think it has the invite link.

rasswanth-s avatar Aug 13 '21 08:08 rasswanth-s

I am not sure, Did you try the opemined.org website, I think it has the invite link.

It's not working

shubhank-saxena avatar Aug 13 '21 09:08 shubhank-saxena

I am not sure, Did you try the opemined.org website, I think it has the invite link.

It's not working

I saw an issue in opened in PySyft regarding the same. https://github.com/OpenMined/PySyft/issues/5891. Could you follow the issue. I am also not sure why it is not working.

rasswanth-s avatar Aug 13 '21 13:08 rasswanth-s

@shubhank-saxena , is the github.head_ref issue fixed? , where only it allows single workflow to be run ,as it would be good to have it PR independent.

rasswanth-s avatar Aug 16 '21 14:08 rasswanth-s

@shubhank-saxena , is the github.head_ref issue fixed? , where only it allows single workflow to be run ,as it would be good to have it PR independent.

Sorry I was little confused with previous comments. With respect to PR, I think github.base_ref works ?

shubhank-saxena avatar Aug 16 '21 18:08 shubhank-saxena

I think github.base_ref won't work ,as it points to the target branch of the pull request.Could you take a look at this documentation: https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions , I think github.ref would work. Could you also test these changed locally in your repo, like the merging the current changes to your forked repo,create two dummy pull requests to check if workflow runs independently .

rasswanth-s avatar Aug 18 '21 16:08 rasswanth-s

https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions

Yes, github.ref is working. It's killing prev CI tasks in the same PR, but not interfering with other PRs. Screenshot 2021-08-20 at 10 27 15 AM

shubhank-saxena avatar Aug 20 '21 04:08 shubhank-saxena

I viewed your forked branch, Could you test by merging your concurrency PR to your main branch and then creating two dummy PR's to check if they are running concurrently.I think testing without merging would revert us back to default scenario.

rasswanth-s avatar Aug 20 '21 05:08 rasswanth-s

I viewed your forked branch, Could you test by merging your concurrency PR to your main branch and then creating two dummy PR's to check if they are running concurrently.I think testing without merging would revert us back to default scenario.

Done!

shubhank-saxena avatar Aug 20 '21 07:08 shubhank-saxena

@rasswanth-s does this need more review?

gmuraru avatar Aug 21 '21 14:08 gmuraru

Yes @gmuraru , we should make the workflow cancellation PR independent, that part is remaining.

rasswanth-s avatar Aug 21 '21 15:08 rasswanth-s

@shubhank-saxena ,I viewed your dummy pull requests in your repo, The workflow are being cancelled for separate PR's, I also tested it in my repo, I think we should try other context variables ,the github.ref is not working.

rasswanth-s avatar Aug 21 '21 15:08 rasswanth-s

@shubhank-saxena ,I viewed your dummy pull requests in your repo, The workflow are being cancelled for separate PR's, I also tested it in my repo, I think we should try other context variables ,the github.ref is not working.

Sorry I wasn't able to replicate the error. To me, it seemed as if it was working as expected. Let me try other context

shubhank-saxena avatar Aug 22 '21 04:08 shubhank-saxena

No issues @shubhank-saxena :+1: ,I think github.job might work, not completely sure.

rasswanth-s avatar Aug 22 '21 07:08 rasswanth-s

@shubhank-saxena any update on this?

rasswanth-s avatar Sep 03 '21 16:09 rasswanth-s

@shubhank-saxena any update on this?

Sorry I was caught up with something. Let me try this scope on my fork and update here asap!

shubhank-saxena avatar Sep 03 '21 16:09 shubhank-saxena