PySyft
PySyft copied to clipboard
wip: refactor: syft error handling
Description
Improves error handling in PySyft by implementing our own result and custom exception.
Proposed changelist for this PR:
- [x] Our own result implementation
- [x] Our own custom error type (SyftException)
- [x] Exception filtering
- [x] Delete PySyftException (see #8919)
- [ ] Refactor
user_code_service - [ ] Integrate with syft response
- [ ] Make it serializable? (future)
Related PRs
- #8919
How has this been tested?
- [x] Added new tests for Result
- [x] Added new tests for SyftException
- [x] Added tests for ExceptionFilter
- [ ] Current tests are green
Checklist
- [x] I have followed the Contribution Guidelines and Code of Conduct
- [x] I have commented my code following the OpenMined Styleguide
- [x] I have labeled this PR with the relevant Type labels
- [x] My changes are covered by tests
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.80%. Comparing base (
4013d3c) to head (2985228). Report is 1 commits behind head on master.
Additional details and impacted files
| Flag | Coverage Δ | |
|---|---|---|
| activemq | ? |
|
| cassandra | ? |
|
| dotnetclr | ? |
|
| gitlab | ? |
|
| hive | ? |
|
| hivemq | ? |
|
| hudi | ? |
|
| ignite | ? |
|
| jboss_wildfly | ? |
|
| kafka | ? |
|
| kube_apiserver_metrics | 97.75% <100.00%> (+0.01%) |
:arrow_up: |
| kubeflow | ? |
|
| kubevirt_api | ? |
|
| kubevirt_controller | ? |
|
| marklogic | ? |
|
| presto | ? |
|
| snmp | ? |
|
| solr | ? |
|
| vertica | ? |
|
| windows_service | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
@FlorentClarret I don't understand what is wrong with the tests. Can you help me?
Would anyone be able to help me with this PR?
@Kyle-Neale, @jmeunier28, @dkirov-dd or someone else?