PyDP icon indicating copy to clipboard operation
PyDP copied to clipboard

Support for Conda

Open chinmayshah99 opened this issue 5 years ago • 9 comments

Feature Description

Supporting for PyDP on Conda.

Is your feature request related to a problem?

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

What alternatives have you considered?

We already have release on pypi, but condo support would be great too.

Additional Context

Add any other context or screenshots about the feature request here.

chinmayshah99 avatar Jun 02 '20 08:06 chinmayshah99

@chinmayshah99 I have been working on getting pydp in the conda-forge, I have it building but have had issues getting it to import and pass tests (even with new changes merged here https://github.com/OpenMined/PyDP/pull/166) I have a WIP PR open here: https://github.com/conda-forge/staged-recipes/pull/11811 if you have any import test thoughts.

oblute avatar Jun 03 '20 14:06 oblute

I'm not versed with conda process, but I'm curious why it's trying to import from pydp import pydp.pydp Logs here: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=170328&view=logs&j=c572e5d5-7ba7-55ce-5575-7ce1d9f7161e&t=81967b5f-0283-5c0b-87c1-e8fdeef842a3&l=331

chinmayshah99 avatar Jun 03 '20 19:06 chinmayshah99

@chinmayshah99 outside of conda behavior, this seemed to be occurring for users pip installing, as seen in this now closed issue: https://github.com/OpenMined/PyDP/issues/126#issue-612520848 In the current behavior, a similar result is found there.

oblute avatar Jun 03 '20 19:06 oblute

It writes, in that issue at the top:

Only one test is executed with make test (a formatting test which
passes), tox produces lots of errors mostly related to this import:

ImportError while importing test module '/root/PyDP/tests/algorithms/test_count.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
algorithms/test_count.py:2: in <module>
    import pydp as dp
../.tox/py36/lib/python3.6/site-packages/pydp/__init__.py:1: in <module>
    from .pydp import *
E   ModuleNotFoundError: No module named 'pydp.pydp'```

oblute avatar Jun 03 '20 19:06 oblute

@oblute Can we take this discussion further on slack?

chinmayshah99 avatar Jun 03 '20 19:06 chinmayshah99

@chinmayshah99 is gitter an okay option? a bit easier for me. i can DM you there. https://gitter.im/

oblute avatar Jun 03 '20 20:06 oblute

Works for me, but the Openmined (pydp) team works on Slack

chinmayshah99 avatar Jun 03 '20 20:06 chinmayshah99

@chinmayshah99 what's the workspace?

oblute avatar Jun 03 '20 20:06 oblute

https://join.slack.com/t/openmined/shared_invite/zt-een94bc6-6ErpR~73SFAdNu5~QH7tlg You can join #lib_pydp and ping me @chinmay(on slack)

chinmayshah99 avatar Jun 03 '20 20:06 chinmayshah99