openkore icon indicating copy to clipboard operation
openkore copied to clipboard

Use one handler for all map_property packets

Open farrainbow opened this issue 9 years ago • 3 comments

Also move to Receive.pm and tweak unpack strings a bit.

farrainbow avatar Dec 20 '16 12:12 farrainbow

@farrainbow What's the best way to test this? I reviewed the code and it looks good. Do I need to go to a PVP map in order to make sure this is working?

itsrachelfish avatar Jan 13 '17 06:01 itsrachelfish

Enable related config options (status_mapType, status_mapProperty) and visit different maps? PVP would be good to check since I didn't really visited one with this.

farrainbow avatar Jan 19 '17 18:01 farrainbow

I think this is good to merge; the only change I will advise is to add a message log to output the map property. This way when people start using it and just in case there are problems, their screenshots or logfiles will contain usable information.

@farrainbow what do you think?

kaliwanagan avatar Jul 09 '17 22:07 kaliwanagan