OpenKore
add new TableFile "pets.txt"
- this file contains the names of the monsters that the pets look like
- this file can be obtained from "data\luafiles514\lua\datainfo\petinfo.lua"
- this is an optional file
If a bot meets a pet "Alice", but before that time it has never seen this monster, then the pet type will always be "Unknown". This patch fixes this problem.
Before:
----------------------------- Pet List -----------------------------
# Name Type Distance Coordinates
0 Poring Unknown #1002 2.2 (275, 234)
--------------------------------------------------------------------
I have an idea for a better one: 1.we can add pet names to monsters.txt file. 2.add a function to overwrite the monsters.txt file if the monster name is different from the default
I have an idea for a better one: 1.we can add pet names to monsters.txt file. 2.add a function to overwrite the monsters.txt file if the monster name is different from the default
need to check the code, but monster.txt uses the name given from server, sometimes some monsters has different names (event/quest) Example: assassin test quest
also take a look at: https://github.com/OpenKore/openkore/blob/29fe641ca35879b62cfb970a9bf9c2c091694b3b/src/Misc.pm#L2320-L2323
current logic: We only add the name of the monster if its id is not found in monters.txt
If I write 1002 abracadabra to monsters.txt, then when poring is encountered, this value will never change.
I believe we should use the current logic (my second option) instead of adding a new file. @alisonrag what do you think?
current logic: We only add the name of the monster if its id is not found in monters.txt
If I write
1002 abracadabrato monsters.txt, then when poring is encountered, this value will never change.I believe we should use the current logic (my second option) instead of adding a new file. @alisonrag what do you think?
will this function be safe? what about assassin test? in this test a lot of same monster have different names for every monster in the screen openkore will re-write the name in monsters.txt
to me the file is better, just like the ragexe
in this test a lot of same monster have different names for every monster in the screen openkore will re-write the name in monsters.txt
Now the ml command reads the original names of the monsters without overwriting the monsters.txt file. After my second patch we will rewrite monster names if the current name does not match monsters.txt
After the thief quest, most likely monsters.txt will contain incorrect monster names, but this will be corrected when the bot meets a real monster. Or we can add a dirty hack for this location
If attack logic use name given from server to me is ok update monsters.txt
long long time ago, me :
- made default monsters.txt from rathena
- made option inside config to turn on/off force actor name Given from server to handle this assasin quest
