openkore icon indicating copy to clipboard operation
openkore copied to clipboard

[items_control] [mon_control] [pickupitems] Allow regex matching

Open lututui opened this issue 7 years ago • 5 comments

Implement #1364, but with a more efficient approach to it.

lututui avatar Jul 02 '18 18:07 lututui

#190

alisonrag avatar Jul 15 '18 14:07 alisonrag

Is this being worked on? How can I possible help?

nizdi avatar Dec 02 '18 19:12 nizdi

nope well, since nothring was done yet, you can help by starting :smile: you can look at the closed pull request that lututui comented and look the code the idea is do that but with a more efficient code

Nipodemos avatar Dec 03 '18 03:12 Nipodemos

@Nipodemos Do you think looking at how macros.pl read RegExp can help with that? I might take a look at that if it helps.

nizdi avatar Dec 06 '18 23:12 nizdi

@nizdi on my opinion, the better would see this code: https://github.com/OpenKore/openkore/pull/1364

analyze , understand and find a better way of doing this, because the way was done it would have a huge performance impact

Nipodemos avatar Dec 07 '18 00:12 Nipodemos