openkore icon indicating copy to clipboard operation
openkore copied to clipboard

Char Move Slot and Rename

Open cydh opened this issue 9 years ago • 6 comments

  • [ ] Code review
  • [ ] QA testing on idRO
  • [ ] QA testing on iRO
  • Move Character Slot
    • Move slot option now will be shown on chracter select (+2 after char slot, after create new char option)
    • Known used packet:
      • char_move_slot (08D4): To send char move request.
      • char_move_slot_reply (08D5): Reply for char move.
  • Rename Character
    • Rename slot option now will be shown on chracter select (+3 after char slot, after move char slot option)
    • Known used packet:
      • char_rename (08FC): To send rename request.
      • char_renamed (08E3): Received a single charinfo for renamed char, only be sent by server if renaming is success.
      • char_rename_result (08FD): Reply of rename request.
  • Misc Edits
    • Delete option will be shown as +3 after char slot
    • Edited received_characters_unpackString unpack string notation to support 'Move Character Slot' and 'Rename Character' feature.
    • Added function 'sub received_characters_unpackString_Min' to unpack 'CharInfo' packet for renamed char.
  • PS: Only tested for idRO server, TODO maybe I'll do some tests for @rAthena

Signed-off-by: Cydh Ramdh [email protected]

cydh avatar May 18 '16 13:05 cydh

I'll rebase this

cydh avatar Nov 04 '16 02:11 cydh

@cydh we have a few more conflicts to solve here :(

kaliwanagan avatar Jul 11 '17 10:07 kaliwanagan

rebased and Allows edits from maintainers

cydh avatar Oct 10 '17 05:10 cydh

Is this pull request still good?? i don't know anything about this

Nipodemos avatar Jul 12 '18 23:07 Nipodemos

@cydh Can we merge this?

alisonrag avatar Jan 03 '19 17:01 alisonrag