lightning
lightning copied to clipboard
Allow Users To Delete Steps With Associated Runs
⚠️ PLEASE DO NOT MERGE THIS PR UNTIL #1825 IS CLOSED ⚠️
Validation Steps
- Run a workflow that has at least 2 jobs
- Select the last job node of that workflow
- Notice that the delete button is no longer disabled
- Hit the delete button to see the job node disappear from your canvas
Notes for the reviewer
Related issue
Fixes #2027
Review checklist
- [x] I have performed a self-review of my code
- [x] I have verified that all appropriate authorization policies (
:owner,:admin,:editor,:viewer) have been implemented and tested - [x] If needed, I have updated the changelog
- [ ] Product has QA'd this feature
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
1825-reference-snapshots@6ee6333). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@
## 1825-reference-snapshots #2149 +/- ##
===========================================================
Coverage ? 89.71%
===========================================================
Files ? 275
Lines ? 9215
Branches ? 0
===========================================================
Hits ? 8267
Misses ? 948
Partials ? 0
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.