lightning icon indicating copy to clipboard operation
lightning copied to clipboard

Fix Credential Modal Closure Error When Workflow Is Unsaved

Open elias-ba opened this issue 1 year ago • 1 comments

Validation Steps

Steps to Reproduce the Bug

  1. Create a Workflow: Navigate to the workflow creation section and initiate a new workflow.
  2. Do Not Save the Workflow: Leave the workflow unsaved.
  3. Attempt to Create a Credential: In the Job view, click on 'New credential' to open the credential type picker modal.
  4. Close the Modal: Close the credential type picker modal without making a selection.
  5. Observe the Crash: Notice that the application crashes.

Steps to Test the Fix

  1. Create a Workflow: Navigate to the workflow creation section and initiate a new workflow.
  2. Do Not Save the Workflow: Leave the workflow unsaved.
  3. Attempt to Create a Credential: In the Job view, click on 'New credential' to open the credential type picker modal.
  4. Close the Modal: Close the credential type picker modal without making a selection.
  5. Verify the Fix: Confirm that the application does not crash and continues to function correctly.

Notes for the reviewer

Related issue

Fixes #2101

Review checklist

  • [x] I have performed a self-review of my code
  • [x] I have verified that all appropriate authorization policies (:owner, :admin, :editor, :viewer) have been implemented and tested
  • [x] If needed, I have updated the changelog
  • [ ] Product has QA'd this feature

elias-ba avatar May 22 '24 17:05 elias-ba

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.09%. Comparing base (655f1d8) to head (75cca41).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2132      +/-   ##
==========================================
- Coverage   90.09%   90.09%   -0.01%     
==========================================
  Files         268      268              
  Lines        8952     8951       -1     
==========================================
- Hits         8065     8064       -1     
  Misses        887      887              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 22 '24 18:05 codecov[bot]