Select the inspector log tab by pushing an URL hash
Validation Steps
- Open the job inspector
- Create a work order
- It shows the log without TabSelector errors after the run is started.
Notes for the reviewer
Uses LV to JS event to push a hash to render the hidden log panel when a new work order is created on job inspector.
Related issue
Fixes #2051
Review checklist
- [x] I have performed a self-review of my code
- [x] I have verified that all appropriate authorization policies (
:owner,:admin,:editor,:viewer) have been implemented and tested - [x] If needed, I have updated the changelog
- [ ] Product has QA'd this feature
Codecov Report
Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.
Project coverage is 90.15%. Comparing base (
ad02ad3) to head (2afc52b).
:exclamation: Current head 2afc52b differs from pull request most recent head 246b1ba
Please upload reports for the commit 246b1ba to get more accurate results.
| Files | Patch % | Lines |
|---|---|---|
| lib/lightning_web/live/workflow_live/edit.ex | 75.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #2095 +/- ##
==========================================
+ Coverage 90.10% 90.15% +0.04%
==========================================
Files 267 254 -13
Lines 8933 8297 -636
==========================================
- Hits 8049 7480 -569
+ Misses 884 817 -67
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@stuartc this is what is pending for the draft: https://openfn.slack.com/archives/C05KZNPEJFN/p1715860844213159?thread_ts=1715856862.925589&cid=C05KZNPEJFN
Replaced by https://github.com/OpenFn/lightning/pull/2147