factorio-server-manager icon indicating copy to clipboard operation
factorio-server-manager copied to clipboard

update javascript dependencies

Open jannaahs opened this issue 3 years ago • 6 comments

This will update all the javascript dependencies.

I've updated tailwindcss to the latest version and moved from the deprecated node-sass to sass.

No errors or warnings when building the frontend.

jannaahs avatar Jun 28 '22 19:06 jannaahs

My plan is to update all dependencies to the latest MAJOR version. That will surely break things. So please update that as well.

knoxfighter avatar Jun 28 '22 19:06 knoxfighter

My plan is to update all dependencies to the latest MAJOR version. That will surely break things. So please update that as well.

@knoxfighter Yeah, I wanted that as well. I tried to look into the MapGenerator again and noticed we could need an update of the dependencies. I'll probably need some time to figure out why the github action is failing, because I can build the frontend locally. I just ask for the code review so you know about it and don't start doing it as well :smile:

jannaahs avatar Jun 28 '22 20:06 jannaahs

Ah, i see, could have created is as DraftPR :) The npm failed previously for windows only, cause of the update to VS2022, but now that the ubuntu is failing, you have to look yourself.

knoxfighter avatar Jun 28 '22 20:06 knoxfighter

It seems to be related to tailwindcss. I'll have a look at it tomorrow or so.

jannaahs avatar Jun 28 '22 20:06 jannaahs

@knoxfighter you can now have a look at it.

jannaahs avatar Jun 29 '22 18:06 jannaahs

@knoxfighter is this ready to be pushed to the develop branch?

louisza avatar Sep 16 '22 05:09 louisza

Writing it down now, since i currently have a look at it and will fix this the following weeks: The update of react-router from v5 to v6 changed the fundamentals completely, therefore i have to rewrite everything that does something with routes (which is most of it ...)

knoxfighter avatar Oct 28 '23 19:10 knoxfighter

Writing it down now, since i currently have a look at it and will fix this the following weeks: The update of react-router from v5 to v6 changed the fundamentals completely, therefore i have to rewrite everything that does something with routes (which is most of it ...)

Wasn't that bad, got a working UI again now :partying_face:

knoxfighter avatar Oct 29 '23 15:10 knoxfighter

If anybody wants to have another look, i would love the feedback. In either case, i will merge this PR on Tuesday.

knoxfighter avatar Oct 29 '23 18:10 knoxfighter

I can try it out but not before the weekend :) But we can always test in production ;)

Mattie112 avatar Oct 30 '23 19:10 Mattie112

@Mattie112 I merge this PR now, i would love if you test the changes on the develop branch. You can either answer here, in a new issue, or on our discord, thank you :)

knoxfighter avatar Nov 01 '23 22:11 knoxfighter

Did not notice any issues 👍

Mattie112 avatar Nov 05 '23 12:11 Mattie112