r-test icon indicating copy to clipboard operation
r-test copied to clipboard

Deprecate AD14 (rebasing of PR #18)

Open andrew-platt opened this issue 2 years ago • 6 comments

Removing AD14 and replacing with AD15. This PR supercedes #18 (that PR sat for too long and got a bit stale).

The following models still require work to determine the appropriate tau1_const parameter in the ADv15 input file:

  • AWT_YFree_WTurb
  • AWT_YFix_WSt
  • WP_VSP_WTurb_PitchFail
  • WP_VSP_WTurb
  • SWRT_YFree_VS_WTurb

5MW_ITIBarge_DLL_WTurb_WavesIrr: (NOTE: this test was disabled due to numerical instabilities) Screen Shot 2023-01-30 at 11 27 17 PM Screen Shot 2023-01-30 at 11 28 36 PM Some tuning could be done on this case to get a better match.

AOC_WSt: Screen Shot 2023-01-30 at 11 44 27 PM Screen Shot 2023-01-30 at 11 44 51 PM

AWT_YFix_WSt: using DBEMT_Mod=2 (Note: channels changed, so the regression test compare does not work) Screen Shot 2023-01-31 at 12 07 50 AM

AWT_YFree_WTurb: (Note: channels changed, so the regression test compare does not work) Screen Shot 2023-01-31 at 12 25 29 AM

SWRT_YFree_VS_EDC01: Screen Shot 2023-01-31 at 12 38 00 AM

SWRT_YFree_VS_WTurb: (NOTE: this test had been disabled due to instabilities and taking forever to run -- shorten it to 20 seconds or leave disabled) Screen Shot 2023-01-31 at 12 50 14 AM

UAE_Dnwind_YRamp_WSt: (NOTE: this test had been disabled due to instabilities) Screen Shot 2023-01-31 at 1 10 58 AM

WP_VSP_WTurb_PitchFail: Screen Shot 2023-01-31 at 1 17 58 AM Screen Shot 2023-01-31 at 1 20 11 AM Screen Shot 2023-01-31 at 1 20 45 AM

andrew-platt avatar Jan 31 '23 06:01 andrew-platt

Closes #43

andrew-platt avatar Feb 01 '23 07:02 andrew-platt

Another (annoying) thing I would add, is if we are redoing the baselines, we could prune some output channels and maybe increase the output dt a bit, to potentially reach output binary files of say 200kb. For instance: -use only only blade number for each output channel name (some kind of rotation between blade 1, 2 or 3).

  • Remove TTDspTwst which is always zero

ebranlard avatar Feb 01 '23 16:02 ebranlard

Another (annoying) thing I would add, is if we are redoing the baselines, we could prune some output channels and maybe increase the output dt a bit, to potentially reach output binary files of say 200kb. For instance: -use only only blade number for each output channel name (some kind of rotation between blade 1, 2 or 3).

* Remove TTDspTwst which is always zero

There are a few other ADAMS outputs that are always zero and could be removed as well. @andrew-platt and I discussed this when removing the ADAMS coupling code.

hkross avatar Feb 01 '23 16:02 hkross

Another (annoying) thing I would add, is if we are redoing the baselines, we could prune some output channels and maybe increase the output dt a bit, to potentially reach output binary files of say 200kb.

Also, if we are redoing baselines.... Since we have updated the way the regression test comparisons work, can we use packed binary output instead of the uncompressed binary output that most of the OpenFAST regression tests use? That would also reduce the file size.

bjonkman avatar Feb 01 '23 16:02 bjonkman

@bjonkman and @ebranlard, I agree pruning outputs and switching to the packed binary files is a good idea.

andrew-platt avatar Feb 01 '23 18:02 andrew-platt

@ebranlard, I agree on switching the name to just AeroDyn in comments and input files. The current version of AeroDyn is significantly different from the original AeroDyn15 -- if we were really following a numbering system we probably should be on AD18 or so by now. So calling it simply AeroDyn is much cleaner going forward. This release is a good time to do that.

andrew-platt avatar Feb 01 '23 18:02 andrew-platt

Closing this PR as #126 now supercedes it.

andrew-platt avatar Jun 12 '24 18:06 andrew-platt

Superceded by #126

andrew-platt avatar Jul 15 '24 16:07 andrew-platt