openfast icon indicating copy to clipboard operation
openfast copied to clipboard

HydroDyn added mass at end of member may not computed properly

Open ebranlard opened this issue 3 years ago • 0 comments

Bug description The variable v2D in the line below is (3x1): https://github.com/OpenFAST/openfast/blob/dev/modules/hydrodyn/src/Morison.f90#L2125 Therefore, the expression matmul(transpose(v2D), v2D) returns a scalar.

I believe the equation should be replaced by matmul( (v2d, transpose(v2d) ) to return a 3x3 matrix.

In my windows gfortran value, the statement is interpreted in a weird way, and the scalar value is placed in the element (3,3) of AM_End, which is quite surprising.

I'll submit a pull request.

OpenFAST Version Openfast dev as of 2/7/2022

ebranlard avatar Feb 07 '22 22:02 ebranlard