oeplatform icon indicating copy to clipboard operation
oeplatform copied to clipboard

[SFS] Allow upper-level hirarchy for CRF-sectors when selecting CRF-sector division

Open u-mueller opened this issue 2 years ago • 8 comments

EDIT by @stap-m: This issue is relatively old but not fully solved. Specific requirements on the implementation are documented in my comment below https://github.com/OpenEnergyPlatform/oeplatform/issues/1523#issuecomment-1865952983

Description of the issue

Selecting CRF sector division in field S7 one is confronted with a myriad of individuals of CRF sectors in the ontology which is far to detailed for most of the users.

and from issue https://github.com/OpenEnergyPlatform/oeplatform/issues/1524 (now also adressed here) If you choose a predifined sector division, say KSG, then only KSG sectors should show up und field: "Which sectors are considered in the study?". This function has been before, but seems to have vanished.

grafik

Ideas of solution

https://github.com/OpenEnergyPlatform/oeplatform/issues/1523#issuecomment-1865952983

u-mueller avatar May 09 '23 09:05 u-mueller

In issue https://github.com/OpenEnergyPlatform/ontology/issues/1333 I had the idea of introducing a special property subsector of instead of using part of.

l-emele avatar May 09 '23 10:05 l-emele

The issue slipped my attention, sorry. Your suggestion would defenitley make sense for me.

u-mueller avatar May 09 '23 10:05 u-mueller

@l-emele can you please review the current state of the sectors and sector devisions in oekg? I think you know the structure best. For me, it looks like still not all sector divisions are selectable. Also, the questions of structuring the sectors, as is the intention of this issue. The idea of subsectors sounds good, but does not seem to work according to your comment here?!

Please see also https://github.com/OpenEnergyPlatform/oeplatform/issues/1524

stap-m avatar Dec 18 '23 10:12 stap-m

The idea of subsectors sounds good, but does not seem to work according to your comment here?!

I implemented a potential solution and it seems to work!

l-emele avatar Dec 18 '23 13:12 l-emele

@l-emele can you please review the current state of the sectors and sector devisions in oekg? I think you know the structure best. For me, it looks like still not all sector divisions are selectable.

I had a quick look:

  • Currently, we have seven sector division classes and seven sector division individuals in the OEO, however in the bundle only four sector divisions are selectable.
  • For NC/BR sector division no sector is selectable. Seems like the is defined by axioms are not used by the OEKG.

l-emele avatar Dec 18 '23 16:12 l-emele

Specified todos from todays oekg meeting with @adelmemariani and @l-emele :

  • [ ] sector divisions: all subclasses and instances of sector division, ideally with hierarchy, plus the option to select "other / no specific division"
  • [ ] for division "others", sector subclasses should be selectable
  • [ ] dependent on the chosen sector devision, sectors should be selectable:
    • the respective sectors are related to sector division via "is defined by" --> show only instances, not classes!
  • [ ] sectors should be shown in a hierarchy:
    • relation "subsector" will provide sector hierarchy
    • still work in progress in the oeo: https://github.com/OpenEnergyPlatform/ontology/pull/1788
  • [ ] sector division instances should not appear in sectors hierarchy, there are still some bugs currenty
  • [ ] at the end: have mouse overs with definitions for sectors, divisions (and technologies)
  • [ ] if no sector division is selected, show a text in the sector field "Please select a sector division first." or similar.

stap-m avatar Dec 21 '23 09:12 stap-m