OpenDream icon indicating copy to clipboard operation
OpenDream copied to clipboard

Adds rudementary ref counting to DreamObject

Open Djiq opened this issue 3 years ago • 8 comments

First pass at ref-counting, i dont have the hardware to test ss13 with this, so if someone could do it and then just send me the list of errors or something it would be great.

Djiq avatar Sep 21 '22 17:09 Djiq

guh

Djiq avatar Sep 21 '22 17:09 Djiq

well it seems like it's working just a little too well since it's destroying some objects prematurely

Djiq avatar Sep 21 '22 17:09 Djiq

A couple of weird things, normal procs are mostly working fine, the only big issues i see rn are native procs, some of them work, some of them work only sometimes, some of them break even tough they do not even USE DreamObjects but strings and such, the exceptions are thrown DM side, or rather, when those native procs break they return nothing, which is interesting.

Djiq avatar Sep 22 '22 19:09 Djiq

ok we're down to 1 test failing for whatever reason

Djiq avatar Sep 24 '22 23:09 Djiq

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 26 '22 04:09 github-actions[bot]

GUH FUCKING FINALLY?

Djiq avatar Sep 26 '22 17:09 Djiq

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 29 '22 16:09 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 20 '22 02:10 github-actions[bot]

This PR is very outdated and would likely need a lot of effort to bring it up to date. And with the advent of #1776, we're probably going to end up depending on C#'s garbage collector instead.

wixoaGit avatar May 14 '24 04:05 wixoaGit