OpenBuilds
Fix leadinRate when Fusion 360 is in Inch mode
Fix the leadinRate when Fusion 360 is in inch mode so that the output is in inches instead of millimeters.
Cannot merge this at this time as I am busy on many changes in laser and plasma working to allow the tools cutHeight to be used if desired
AND
have already fixed this issue with 1 line in onParameter
plasma.leadinRate = toPreciseUnit(value,MM);
if you call toPreciseUnit() in all cases, then leadinRate gets set to the correct units no matter what the current unit setting is, so no need for any other logic.
Your change to the line at 1973 is useless I believe, the G10 line makes no moves so a feedrate there is not useful, leadinfeedrate is already set in onCommand for the approach move.
My machine runs a stock Uno 3 and I never have any issues requiring a reset so I don't understand what you are fixing by avoiding G53. G53 is only used for safety Z moves, and the user selected WCS (default G54) is used for all other moves. G53 moves will never be removed from this post as this is a critical safety factor, to raize Z as high as it will go before initial approach moves, industry standard stuff.
I have merged the lines like title: "SPINDLE on/off or Plasma Pierce Delay", as they clarify the dual use of the spindle delay nicely, thanks.
The only thing I intended to submit for merging is the fix for the leadinRate when in inch mode - if you've got another fix for that it will suffice. The other changes were part of a previous commit to my clone's master, but not intended to go in to the main repo. I just didn't have a good way to remove them from my history. I was testing working around a problem with my old Uno based machine, but I've sent switched to an ESP32 (grblHal) microcontroller and the G53/G54 stuff works just fine as-is.
Thank you for rectifying the issue with the inch-mode. I'll keep an eye on the repo and test out your changes once they are completed. I am very interested in fixes that will make it easier to work with the plasma cutter I built. Thanks for the work on this!
-Andrew Sandoval