OpenBuilds-CONTROL icon indicating copy to clipboard operation
OpenBuilds-CONTROL copied to clipboard

XYZ Probe Offset Center: X is using Y offset

Open sharmstr opened this issue 2 years ago • 1 comments

Hey Peter. Got a report on fb that XYZ probe with center offset isnt setting X correctly. I havent tested on the machine but the code looks likes its wrong to me.

if (probemode.stock.position == "c") { // fl, fr, rl, rr, c
    template += `Stock x:` + probemode.stock.x + `\n`;
    template += `Stock y: ` + probemode.stock.y + `\n`;
    template += `Offset: Center:\n`;
    template += `Offset x:` + probemode.stock.x / 2 + `\n`;
    template += `Offset y: ` + probemode.stock.y / 2 + `\n`;
    stockoffset.x = probemode.stock.y / 2
    stockoffset.y = probemode.stock.y / 2
  }

Shouldnt stockoffset.x be probemode.stock.x / 2?

sharmstr avatar Sep 05 '23 16:09 sharmstr

Yeah does look wrong. Keeping open so we can get to it - haven't been able to release for a while due to codesigning issues

petervanderwalt avatar Sep 06 '23 18:09 petervanderwalt