sbt-openapi-generator icon indicating copy to clipboard operation
sbt-openapi-generator copied to clipboard

fix: start releasing to Sonatype

Open ckipp01 opened this issue 3 years ago • 8 comments

Since bintray is no longer an option, this sets up sbt-ci-release which is commonly used for sbt plugins to do releases. I'll include some comments inline.

What is yet needed

In order for this to work you'll need to ensure the following secrets are set up for this repo:

  • PGP_PASSPHRASE
  • PGP_SECRET
  • SONATYPE_PASSWORD
  • SONATYPE_USERNAME

You can find descriptions of what these are and how to get them all here. This will allow this plugin to be published just like anything else under https://repo1.maven.org/maven2/org/openapitools/. This setup also will start publishing snapshots on merge into master. To trigger a new release, all you'd need to do is push a new tag.

Let me know if there is anything you'd like further explanation on.

Closes #35

ckipp01 avatar Aug 31 '22 10:08 ckipp01

Hi @wing328, sorry to tag you directly. Is this PR something that would improve on the SBT plugin? This way it would be deployed into maven central, like the other openapi artifacts

nMoncho avatar Oct 14 '22 12:10 nMoncho

@ckipp01 first of all, thanks for the PR.

@nMoncho no need to sorry. Generally we welcome enhancements but I didn't have time to review this as there're so many PRs to the openapi-generator repo.

Have you reviewed and tested it somehow?

wing328 avatar Oct 17 '22 03:10 wing328

Have you reviewed and tested it somehow?

Well there isn't a great way to test this since it's the CI release procedure. However, again, this is the same approach used in most modern sbt plugins. Just to give an example here is another I maintain, sbt-scoverage with a minimal, but similiar setup.

The best way to test this is essentially to merge this branch. If the secrets for publishing that I mentioned are set up correctly we'll end up with a new snapshot on sonatype snapshots. If that doesn't work, I'm happy to trouble-shoot and pr another fix.

Apart from that, you can locally still see that sbt version gives you what you'd expect, ^scripted still works, and publishLocal still publishes as you'd expect. Let me know how you'd like to proceed.

ckipp01 avatar Oct 20 '22 06:10 ckipp01

thanks for reviewing the change.

i'll give it a try next week

wing328 avatar Oct 20 '22 13:10 wing328

thanks for reviewing the change.

i'll give it a try next week

@wing328 I've been following up on this for a while now. Can I ask where this stands?

Thank you :pray:

hochgi avatar Jan 26 '23 06:01 hochgi

Any update here?

jshuttAH avatar May 03 '23 16:05 jshuttAH

@jrouly , @ckipp01, @wing328, friendly ping. Thanks for working on this PR. What's left to get it across the line? It would be great to be able to use this plugin on a project I'm working on.

fernandoacorreia avatar Mar 18 '24 12:03 fernandoacorreia

published to https://repo1.maven.org/maven2/org/openapitools/sbt-openapi-generator_2.12_1.0/7.3.0/ (via running sbt publish locally)

please give it a try when you've time

wing328 avatar Mar 26 '24 03:03 wing328