openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[JAVA][Spring]Use @RequestParam when param is not a file

Open Zomzog opened this issue 5 years ago • 7 comments

Based on this I have replaced RequstPart with RequestParam when the part is not a file.

Ping technical committee: @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @lwlee2608 (2019/10) @bkabrda (2020/01)

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • [x] Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • [x] File the PR against the correct branch: master
  • [x] Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Zomzog avatar Oct 25 '20 21:10 Zomzog

The last commit has been amened to restart CI jobs, it looks ok now.

Zomzog avatar Oct 31 '20 13:10 Zomzog

Rebase done, must fix #7794

Zomzog avatar Jan 26 '21 20:01 Zomzog

is this going out anytime soon ?

osimosu avatar Aug 22 '21 17:08 osimosu

Hello everyone,

any ETA for this to be shipped?

Thanks, Dan

d35h avatar Oct 09 '21 19:10 d35h

Hello.

While waiting for the fix on future versions, is there a workaround to be able to make the spring generation work correctly? I am in 5.1.1 of the openapi-generator-maven-plugin plugin.

thanks in advance

simon-exp avatar Mar 25 '22 14:03 simon-exp

@Zomzog @Dretch Can I help somehow to get this fix merged?

DaSilva2010 avatar May 18 '22 13:05 DaSilva2010

Any ETA on this?

Thanks Madan

madanepuri avatar Aug 02 '22 22:08 madanepuri