Default to OAS-compliant handling of additionalProperties
This changes the default value for disallowAdditionalPropertiesIfNotPresent from true to false, which means that the generator will now, by default, produce code that complies OpenAPI standards with respect to the handling of additionalProperties.
Note that a number of example configs did not have to be updated as a result of this change, which indicates that the disallowAdditionalPropertiesIfNotPresent option had no effect on the generators used in those examples.
Closes #21169 Closes #16575 (duplicate)
PR checklist
- [x] Read the contribution guidelines.
- [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
- [x] Run the following to build the project and update samples:
(For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed. - [ ] File the PR against the correct branch:
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks) - [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@wing328 When you have a moment, please take a look. To provide a more complete fallback for this change, I added a new config flag for Python generators to maintain pre-existing behavior around the disallowAdditionalPropertiesIfNotPresent option. Let me know if you'd like to see this handled differently.