openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[CSharp] optional properties use boxed type [fix #19461]

Open marcel-huber-ptv opened this issue 1 year ago • 1 comments

Fixes the bug described in #19461 by only using the primitive variants if a property is both required and non-nullable.

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)

marcel-huber-ptv avatar Aug 27 '24 12:08 marcel-huber-ptv

I am not sure what to do about the failing checks. I updated docs and samples, so I believe those shouldn't fail. Maybe my change also is a breaking change to cause the other checks to fail. Please let me know, how I can proceed with this PR.

marcel-huber-ptv avatar Aug 27 '24 13:08 marcel-huber-ptv

I close this PR, because the solution @wing328 proposed in #19461 works for us, this PR is no longer needed from our side.

marcel-huber-ptv avatar Aug 29 '24 09:08 marcel-huber-ptv