openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[csharp] Mustache fully qualify namespace for Path

Open alfredo-accuris opened this issue 1 year ago • 3 comments

The generated code of Csharp get a fully quallify namespace for PATH

using Path = global::System.IO.Path;

PR checklist

  • [X] Read the contribution guidelines.
  • [X] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [X] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [X] File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [X] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @mandrean @shibayan @Blackclaws @lucamazzanti @iBicha

alfredo-accuris avatar Aug 13 '24 21:08 alfredo-accuris

Intends to fix #19344

alfredo-accuris avatar Aug 13 '24 21:08 alfredo-accuris

thanks for the PR

with name mapping option for fallback, can this PR target upcoming minor release (breaking with fallback allowed)?

ref: https://github.com/openapitools/openapi-generator/blob/master/docs/customization.md#name-mapping

wing328 avatar Aug 19 '24 04:08 wing328

This is not a breaking change. It is only fully qualifying a method, a very safe thing to do. I don't see any harm in merging it now.

devhl-labs avatar Aug 19 '24 06:08 devhl-labs