openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

#15985 Change options from any to RawAxiosRequestConfig in typescript-axios

Open MarekBodingerBA opened this issue 1 year ago • 0 comments

Fixes #15985, for some reason all the versions of options have the correct type (RawAxiosRequestConfig) except "factory interface" versions of the functions.

For example, the changed line is from any (in the original): https://github.com/OpenAPITools/openapi-generator/blob/640ef9d9448a4a008af90eca9cc84c8a78ec87ec/samples/client/petstore/typescript-axios/builds/default/api.ts#L739 To RawAxiosRequestConfig (in this pull request): https://github.com/OpenAPITools/openapi-generator/blob/d5d4c058af17b5321000eac057403980c6f56fb3/samples/client/petstore/typescript-axios/builds/default/api.ts#L739 As you can see it calls this method in the next line, where the type is correctly present: https://github.com/OpenAPITools/openapi-generator/blob/d5d4c058af17b5321000eac057403980c6f56fb3/samples/client/petstore/typescript-axios/builds/default/api.ts#L619 Another instance with the correct type: https://github.com/OpenAPITools/openapi-generator/blob/640ef9d9448a4a008af90eca9cc84c8a78ec87ec/samples/client/petstore/typescript-axios/builds/default/api.ts#L836

PR checklist

  • [X] Read the contribution guidelines.
  • [X] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [X] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [X] File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [X] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka

MarekBodingerBA avatar Jun 19 '24 12:06 MarekBodingerBA