openapi-generator
openapi-generator copied to clipboard
[BUG] Duplicate models are produced when a file is referenced multiple times by different paths
Bug Report Checklist
- [x] Have you provided a full/minimal spec to reproduce the issue?
- [x] Have you validated the input using an OpenAPI validator (example)?
- [x] Have you tested with the latest master to confirm the issue still exists?
- [x] Have you searched for related issues/PRs?
- [x] What's the actual output vs expected output?
- [ ] [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description
A recent openapi-generator release upgraded swagger-parser to 2.1.22. That upgrade resolved a bug where the parser was unable to resolve relative refs to real file paths, but it introduced a new bug where the parser creates duplicate schema objects for each unique relative path, rather than reusing an existing schema when two (or more) relative paths are equivalent.
openapi-generator version
v7.5.0
OpenAPI declaration file content or url
Refer to https://github.com/swagger-api/swagger-parser/pull/2105 for a reproduction OpenAPI spec.
Generation Details
Steps to reproduce
Related issues/PRs
Suggest a fix
I don't think there's a way to work around this issue in openapi-generator itself; instead it requires a fix in swagger-parser that is then pulled in to this project in a future parser upgrade.