openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

Fix build issue when using dotnet 8.0.300

Open omer-za opened this issue 1 year ago • 2 comments

https://github.com/dotnet/sdk/issues/40445

PR checklist

  • [ ] Read the contribution guidelines.
  • [ ] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ ] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [ ] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [ ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

omer-za avatar May 20 '24 10:05 omer-za

@wing328 Can you please review and help me push it forward ?

omer-za avatar May 20 '24 10:05 omer-za

thanks for the PR. i've filed https://github.com/OpenAPITools/openapi-generator/pull/18720 based on your PR with updated samples.

all tests passed.

if no further feedback, I'll merge this PR later this week.

cc @devhl-labs

wing328 avatar May 21 '24 07:05 wing328

Thanks @wing328 ! when is the next expected release ?

omer-za avatar May 23 '24 07:05 omer-za

https://github.com/OpenAPITools/openapi-generator/milestones

you can use customized templates (e.g. -t via CLI) for the time being

wing328 avatar May 23 '24 08:05 wing328