openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[GO][Client] Generated GO Client Time Query Param Millisecond Resolution Fix

Open gonzogomez opened this issue 1 year ago • 2 comments

Generated Go Client code now uses time.RFC3339Nano instead of time.RFC3339, so we do not loose the millisecond resolution.

Addresses https://github.com/OpenAPITools/openapi-generator/issues/18672

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [ ] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [ ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@lwj5 @wing328

gonzogomez avatar May 14 '24 19:05 gonzogomez

thanks for the PR. would that break users who do not need the millisecond?

wing328 avatar May 15 '24 03:05 wing328

thanks for the PR. would that break users who do not need the millisecond?

No problem!! This will not be a breaking change. The t.Format(time.RFC3339Nano) call is done on a time object. The time object will return the formatted timestamp as a string regardless of whether the timestamp includes fractions of a second or not. Time object that has the following timestamp 2024-05-14 02:43:39 will still be converted to 2024-05-14T02:43:39Z with the t.Format(time.RFC3339Nano).

gonzogomez avatar May 15 '24 13:05 gonzogomez

@gonzogomez thanks for the explanation. Let's give it a try.

wing328 avatar May 19 '24 09:05 wing328