openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[GO] #18651 - Add assert constraints checks for complex types in the model tem…

Open avivlevitski-vlz opened this issue 1 year ago • 1 comments

#18651 Add assert constraints checks for complex types in the model template. Every nested model will be validated (if necessary according to the component schema format).

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5

avivlevitski-vlz avatar May 13 '24 10:05 avivlevitski-vlz

https://github.com/OpenAPITools/openapi-generator/actions/runs/9062950157/job/24930473003?pr=18654

can you please review the test failure when you've time?

wing328 avatar May 14 '24 03:05 wing328

thanks for the PR. let's give it a try

wing328 avatar May 15 '24 08:05 wing328