openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[REQ] [ASPNETCORE] Add value types for the ASPNETCORE generator

Open evgenii-kuznetsov opened this issue 1 year ago • 3 comments

Requirement: #18557

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

evgenii-kuznetsov avatar May 12 '24 10:05 evgenii-kuznetsov

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

wing328 avatar May 13 '24 12:05 wing328

please follow step 3 to update the samples so that the CI can verify the change.

wing328 avatar May 13 '24 12:05 wing328

Dear technical committee members, could you please check this pull request if you have time. CC: @mandrean, @shibayan, @Blackclaws, @lucamazzanti, @iBicha

evgenii-kuznetsov avatar May 20 '24 07:05 evgenii-kuznetsov

thanks for the PR, which has been merged

wing328 avatar May 21 '24 07:05 wing328