openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

Bump Rust edition to 2021 and a few crates

Open maxnachlinger opened this issue 1 year ago • 4 comments

Bump Rust edition to 2021 and a few crates. Fixes: https://github.com/OpenAPITools/openapi-generator/issues/18609

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05) @jacob-pro (2022/10)

maxnachlinger avatar May 08 '24 13:05 maxnachlinger

thanks for the PR. can you please take a look at https://github.com/OpenAPITools/openapi-generator/actions/runs/9002489911/job/24730910208?pr=18608 when you've time?

wing328 avatar May 08 '24 13:05 wing328

@wing328 - I opened this PR too quickly, sorry for the churn. Fixing the build now :(

maxnachlinger avatar May 08 '24 13:05 maxnachlinger

Please take our time. Appreciate the PR to bump the dependencies to newer versions.

If you need help, let me know. (ping me via Slack)

wing328 avatar May 08 '24 13:05 wing328

@wing328 - PR is ready for a review

maxnachlinger avatar May 08 '24 15:05 maxnachlinger

lgtm. thanks for the PR.

wing328 avatar May 09 '24 02:05 wing328