openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[REQ] Switch deprecated retrofit2-kotlinx-serialization-converter for first party kotlinx-serialization

Open larst-ingka opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe.

Back in the middle of march 2024 jakewharton retrofit2-kotlinx-serialization-converter was deprecated as it was moved to a first party converter. This means that any further improvements to the converter will happen in the retrofit repository.

Describe the solution you'd like

Switch out the retrofit converter factory used for kotlinx_serialization with the new first party converter.

Describe alternatives you've considered

Given that no further development is to be expected on the deprecated repository, and the fact that the repo was moved to a first party converter with no code changes between, I don't see any other clear options.

larst-ingka avatar May 07 '24 08:05 larst-ingka

thanks for opening an issue (ticket) to track this.

the switch sounds good

may I know if you've time to contribute a PR for that?

let me know if you need some good starting points.

wing328 avatar May 08 '24 07:05 wing328

Yeah, that would not be a problem.

A preliminary timeline when I'd be available to contribute it would be early-mid next week.

Sure, I've had a look at blame for earlier similar contributions, as well as the CONTRIBUTING guidelines, but if theres some other goodies that would be helpful to me, please don't hesitate.

larst-ingka avatar May 08 '24 10:05 larst-ingka

yup, previous PRs would be a good starting point too.

look forward to your PR.

thanks in advance for your contributions

wing328 avatar May 08 '24 10:05 wing328

The pr was merged, so ill close this REQ now

larst-ingka avatar May 13 '24 11:05 larst-ingka