openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[C++][Pistache] Compile error when nesting component/schema reference objects (#16711)

Open keyjh2 opened this issue 1 year ago • 0 comments

When components/schema/ reference other objects, validate() was getting called on the referenced objects with no arguments. The return value was void, but checked as if it was a boolean value.

  • Added message arguments to fixed compiler error in model-source.mustache.
  • Added integration test for this issue (bin/configs/cpp-pistache-server-cpp-pistache-nested-schema-refs.yaml).
  • Added new schema for integration test (modules/openapi-generator/src/test/resources/3_0/nested-schema-refs.yaml).
  • Added generated code from integration test (samples/server/petstore/cpp-pistache-nested-schema-refs/)
  • Removed unused model source files from previous integration test (samples/server/petstore/cpp-pistache/model).
  • Removed pistache install script. Pistache was already getting built as a dependency by CMake.

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. - @ravinikam @stkrwork @etherealjoy @martindelille @muttleyxd

keyjh2 avatar May 07 '24 00:05 keyjh2