openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[GO] fix post process file type

Open mathewab opened this issue 1 year ago • 1 comments

fixes https://github.com/OpenAPITools/openapi-generator/issues/10718

The file type passed to postProcessFile by DefaultCodegen used to be supporting-mustache and supporting-common earlier. This has been changed to supporting-file in https://github.com/OpenAPITools/openapi-generator/pull/6357 and https://github.com/OpenAPITools/openapi-generator/pull/7366.

AbstractGoCodegen was never updated to match this change, and accepts only supporting-mustache. This PR changes it to accept supporting-file instead.

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

mathewab avatar Apr 27 '24 16:04 mathewab

@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5

mathewab avatar Apr 27 '24 17:04 mathewab

thanks for the fix, which looks good to me.

wing328 avatar Apr 28 '24 12:04 wing328